Impact calc return impact forecast #1179
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luseverin
requested review from
chahank,
emanuel-schmid and
peanutfun
as code owners
Member
|
We should raise an error if |
…saving impact matrix
chahank
reviewed
Dec 8, 2025
chahank
reviewed
Dec 8, 2025
chahank
reviewed
Dec 8, 2025
chahank
reviewed
Dec 8, 2025
chahank
reviewed
Dec 8, 2025
Collaborator
Author
|
TODO:
|
…/CLIMADA-project/climada_python into impactCalc_return_impactForecast
…/CLIMADA-project/climada_python into impactCalc_return_impactForecast
chahank
reviewed
Dec 9, 2025
climada/engine/impact_forecast.py
Outdated
|
|
||
| @at_event.setter | ||
| def at_event(self, value): | ||
| """Set the total exposure value close to a hazard""" |
Member
There was a problem hiding this comment.
What does that mean? This is not what at_event does.
Suggested change
| """Set the total exposure value close to a hazard""" | |
| """Set the total exposure value close to a hazard""" |
chahank
reviewed
Dec 9, 2025
climada/engine/impact_forecast.py
Outdated
| @at_event.setter | ||
| def at_event(self, value): | ||
| """Set the total exposure value close to a hazard""" | ||
| LOGGER.warning("at_event for forecasts is not yet implemented.") |
Member
There was a problem hiding this comment.
I think at_event is implemented for forecasts. This is confusing.
chahank
reviewed
Dec 9, 2025
Comment on lines
+126
to
+127
| aai_agg = np.sum(exposure.gdf["value"]) * hazard.frequency[0] | ||
| eai_exp = np.ones(exposure.gdf.shape[0]) * hazard.frequency[0] |
Member
There was a problem hiding this comment.
For the ImpactForecast tests, yes:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR:
This PR fixes #1138 #1135
PR Author Checklist
develop)PR Reviewer Checklist